On 04/29/10 07:07 PM, Brock Pytlik wrote:
On 04/28/10 09:07 PM, Shawn Walker wrote:
Greetings,
The following webrev contains changes for the following issues:
15762 client support for filesystem-based repository access
10244 caching dictionaries as a class variable prevents multi-image
and repo search
14802 ability to have separate read / write download caches
15763 test suite should not start depot server unless necessary
15764 file_manager insert needs to stat() less and return more
webrev:
http://cr.opensolaris.org/~swalker/pkg-file/
[snip]
modules/query_parser.py
I think a comment explaining that _global_data_dict must be defined in a
subclass for this class to be functional is probably called for here. If
python had java's notion of an abstract class, we should now use it, but
I couldn't find any suggestion that that was the case.
Yeah, I've clarified the comment for the TermQuery class.
file_manager.py
line 215: typo on "inserted"
I was mostly looking at the search changes and for collisions with the
signing stuff. Both look ok to me. Looking forward to seeing this in
action.
Thanks,
-Shawn
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
