The comments on 509 and 520 should be comments. You should add another
line between 508 and 509 using the """ .... """ construction as a
docstring for the test case. Providing a bug id or description of what's
being tested is usually what's given.
Thanks,
Brock
On 07/ 2/10 04:02 AM, Saurabh Vyas wrote:
Thanks Brock for reviewing the fix.
I have added the test cases too, new webrev :
http://cr.opensolaris.org/~saurabhv/Bug-16211-rev2/
please let me know you comments.
Thanks,
~Saurabh
Brock Pytlik wrote:
The change looks fine to me. I'd like to see two test cases. One for
pkg list -u, and another for pkg list -u <pkg-name>.
Brock
On 06/30/10 04:13 AM, Saurabh Vyas wrote:
Hi All,
A gentle request, if someone can please spend some time to review
this fix.
Thanks in advance,
~Saurabh
Saurabh Vyas wrote:
Hi All,
Please review the fix for and let me know your comments.
Bug-id : 16211 pkg list -u claims no such package installed when
there are simply no upgrades
webrev : http://cr.opensolaris.org/~saurabhv/Bug-16211-rev0/
I ran a quick test to verify :
v...@opensolaris:~/NewImage$ pkg list -a
NAME (PUBLISHER) VERSION STATE UFOXI
helloworld 1.1 installed -----
v...@opensolaris:~/NewImage$ pkg list -u helloworld
No specified packages have newer versions available.
v...@opensolaris:~/NewImage$ pkg list -u
No installed packages have newer versions available.
Cheers,
~Saurabh
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
