On 08/20/10 06:24 PM, Bart Smaalders wrote:
http://cr.opensolaris.org/~barts/16108/ 16108 boot environments should be created by default only when needed 13305 change-variant --be-name doesn't affect new BE name This also cleans up verbose messaging, and provides better output in general about what the pkg client is doing.
src/client.py: line 161: no way to control be behaviour for fix? src/pkg.1.txt: line 254: s/. See/. See/ lines 260, 542, 579: s/upgrade/operation/ ? src/modules/client/actuator.py: line 162: nit: missing newline between functions lines 165, 168: line wrapping? src/modules/client/api.py: line 287: move this under if clause on 289? line 295: Comment here, but no code to do that? line 308: stray newline? line 313: nit: s/. Toss/. Toss/ line 314: nit: s/one/one./ line 319: why not move 315 here and avoid unused assignment? line 562: stray newline? line 2850: s/on/in/ ? line 2940: nit: add extra newline (two between class definitions) src/modules/client/imageplan.py: lines 159, 166, 168: do these wrap at 80? Otherwise, seems right to me. Cheers, -Shawn _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
