On 09/20/10 12:39 PM, Edward Pilatowicz wrote:
src/modules/client/pkg_solver.py- this isn't so pretty: if da.attrs.get("root-image", "").lower() == "true": why not have the dependancy action class translate this property (if present) into a boolean so you could just do: if da.attrs.get("root-image", ""):
There's a significant amount of runtime overhead in parsing action data. Pushing the cost of comparison down to consumers of the data is cheaper than trying to enforce it during action parsing.
That's why we avoid doing any transformation of action data unless absolutely necessary.
-Shawn _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
