On 09/17/10 01:14 PM, Bart Smaalders wrote:
This is the fix for:
16327 New dependency types desired
It adds three new dependency types:
require-conditional - dependency on minimum version of specified package
if predicate package is installed at specified version or newer.
This
require-any - dependency on minimum version of any of the specified
packages.
require-origin - specified package must be at this version or newer
in order to install this package; if root-image=true, dependency is
on version installed in / rather than image being modified.
http://cr.opensolaris.org/~barts/16327/
src/modules/actions/depend.py:
line 24: copyright update needed
line 59: s/orign/origin/
lines 257-260: Couldn't None be returned for some of these? And
if so, wouldn't that impact line 268?
line 318: s/applie/applies/ ?
src/modules/client/pkg_solver.py:
line 24: copyright update needed
line 931: leftover debug?
line 1101: s/[ self/[self/
line 1159: s/[ pkg./[pkg./
line 1316: s/ publishers/, publishers/ ?
line 1319: I understand why it skips it for checking if it isn't
installed, but will it end up being treated as a basic require
dependency by the solver for the image being modified later?
For example, based on your test case where pkg11 has a require-
origin dependency on SUNWcs, will SUNWcs be installed in the
target image if it isn't already?
line 1326: the '%s' should be named expandos (e.g. %(inst_ver)s, etc.)
src/tests/cli/t_pkg_install.py:
line 3257: nit: additional newline needed
lines 3225-3256: no simulate_liveroot testing needed?
Otherwise, seems right to me.
-Shawn
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
