On 09/10/10 01:55 PM, [email protected] wrote:
Hi Shawn,
On Thu, Sep 09, 2010 at 03:45:07PM -0700, Shawn Walker wrote:
Greetings,
The following webrev contains fixes for the following issues:
16998 transport should support publisher-specific write and read caches
9572 FactoredManifest should allow consumers to specify cache location
14613 api should provide access to last_modified time of image
16261 ActionExecutionError stringify references unbound variable
16921 test suite can traceback on unit test failure when
attempting to restore pwd
16996 manifest class should support pathname for setting content
16997 FactoredManifest class should not encode knowledge of how
manifests are stored
17006 api_errors references undefined exception class
webrev:
http://cr.opensolaris.org/~swalker/pkg-iformat/
This looks good. I just had one question.
image.py:
- The changes to temporary_dir() and temporary_file(), as well as the
change to line 575, made me wonder if the image should keep a list
of temporary directories that it creates? We could then remove them
in one pass; however, having mutliple image objects over the
lifetime of a process could complicate cleanup.
Yes; the multiple image objects aspect is one of the reasons why I
punted on this.
-Shawn
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
