Shawn Walker wrote:
> http://cr.opensolaris.org/~swalker/pkg-iformat/
image.py:
- line 294: while you're already there, could you fix the grammar here?
In particular, "anchor ... were".
- line 536: why is tmpdir a public member? I see that statedir is used
twice in the testsuite, at least, though even there I wonder if it
might be worthwhile making it private and using the mangled name in the
testsuite.
- line 550, 554: while you're here, could you torch the unnecessary
continuation characters? (Is there a pylint setting for that?)
- line 2329: should we only remove a cache dir if it's not readonly?
manifest.py:
- Is it worth asserting that both pathname and contents are not set in
the FactoredManifest constructor, as in Manifest.set_content()?
pull.py:
- line 53: no need for the parens
pkgdiff.py:
- line 92, 98: why not use pathname= here?
Danek
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
