On 09/13/10 11:33 AM, Danek Duvall wrote:
Shawn Walker wrote:
http://cr.opensolaris.org/~swalker/pkg-iformat/
image.py:
...
- line 536: why is tmpdir a public member? I see that statedir is used
No reason; I'll change tmpdir to private.
twice in the testsuite, at least, though even there I wonder if it
might be worthwhile making it private and using the mangled name in the
testsuite.
I'll change statedir to "protected" (e.g. Image._statedir).
- line 550, 554: while you're here, could you torch the unnecessary
continuation characters? (Is there a pylint setting for that?)
Sadly, pylint doesn't seem to have a check for this, although I've found
examples of how to implement a custom plugin for pylint that does this.
- line 2329: should we only remove a cache dir if it's not readonly?
No; thanks for spotting that.
Elided items have been resolved.
Thanks,
-Shawn
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
