Shawn Walker wrote:
> http://cr.opensolaris.org/~swalker/pkg-iformat/
license.py:
- Why support version 3 images in get_local_opener(), but nowhere else?
api.py:
- line 278: why the explicit newline here?
imageconfig.py:
- The image configuration is at version 3, but the image layout is at
version 4?
- line 139: should the image config file have a version, too?
- line 127: Why isn't this a PropInt?
- line 399: Perhaps we should have a constant for the latest version?
image.py:
- line 487: Can you explain why this is safe?
- line 618: "fallback"
- line 632: Can you explain why this is safe?
- line 638: this can move out one level
- line 697: If self.version < 4 and self.__user_cache_dir, then
__write_cache_dir doesn't end up getting set. Ditto with
_incoming_cache_dir. Is that a problem?
- line 701: was the "__" prefix used for directory names? Why do we need
it now?
- line 799, 806, 816: should we set self.version to self.CURRENT_VERSION
successfully completing update_format()?
- line 871: why sorted()?
- line 1036: should we handle EXDEV specially?
- line 1141: I thought I saw somewhere else that you'd moved whether a
publisher was disabled or not directly into the configuration file,
rather than continuing to have a separate one.
- line 1168: How does this work if there are mountpoints beneath imgdir?
Are we affected by the recently-putback PSARC/2010/385?
- line 1313: I'd be really careful about assuming we understand versions
later than ourselves. In fact, I'm not sure I'd do it at all.
- line 1842: Why do we have to iterate over all installed packages,
rather than just iterating until we get to the one we care about? Is
there some chance we can run into a package we think is installed from
multiple publishers, and we choose the last?
- line 1850, 1864: Can you explain why?
- line 3038: Should we warn the user that what they're doing is not
necessarily representative of the command that would actually get run?
Danek
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
