On 11/10/10 07:16 PM, Danek Duvall wrote:
Shawn Walker wrote:
If there was a parsing error, no. But if we couldn't get any version
information from configuration at all, then yes, the fallback gets
used as a last ditch attempt to determine what sort of image is being
used.
So in what kind of scenario do we end up here -- if you decided to keep the
format of the config file, but rearrange the structure so that the version
attribute was found somewhere else?
This fallback path is also used during image upgrades. In the case of
version 3 and version 2 images, the image configuration doesn't record
the image version, so I have to detect the version of the image based on
structure.
I also think it would be pretty silly to move the location of the image
version in the structure as that would defeat the whole purpose of
adding a versioning mechanism.
I felt it was best for the client to try as hard as possible to make the
image useable rather than simply fail. But if you want me to change the
path where I'm falling back to trying to detect the type of image based
on structure, and the image looks like it's a version 4 (or possibly
newer) image, and have the client fail with an exception, I'm willing to
compromise and do that.
But otherwise, all of the other checks I have in place are needed for
the basic upgrade process to work.
-Shawn
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
