On 10/12/10 03:37 PM, [email protected] wrote:
On Tue, Oct 12, 2010 at 02:36:30PM -0700, Shawn Walker wrote:
Greetings,
The webrev linked below contains changes for the following items:
7276 /var/pkg metadata needs reorg (looks busy)
5750 add versioning information for image meta data (cfg_cache, etc.)
7273 manifests should be arranged in a hierarchy by publisher
17190 licenses are installed into directories for each leading '/'
component in name
17199 packages updates should only require license acceptance when
licenses change
webrev:
http://cr.opensolaris.org/~swalker/pkg-iformat/
doc/client_api_versions.txt:
- line 2: Did you mean to write "incompatible" here instead?
No, actually. The interface itself is compatible.
client/image.py:
- lines 400 and 406: Would it be better to check that these simply
exist, instead of checking what type of object it actually is. If
someone decides to move the image config and then symlink to it we'd
fail this test, even though everything would probably otherwise just
work.
I'm not inclined to support symlinks :) With that said,
os.path.isfile() will return true if it's a link pointing at a file.
That's one of the annoying things about os.path.is* sometimes.
-Shawn
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss