Hi all,
Just wondering if anyone has had a chance to look at this code review?
I'd like to putback without the fork/exec of pkgmogrify for now if
possible and address that in a future putback.
The main thing we're missing by not having that, is the ability to
automatically add actuators to SMF manifests that were previously
delivered by the "manifest" class. Perhaps running other transforms
would be good too, but they're a nice-to-have.
Webrevs below.
cheers,
tim
-------- Forwarded Message --------
From: Tim Foster <[email protected]>
To: Edward Pilatowicz <[email protected]>
Cc: [email protected]
Subject: Re: [pkg-discuss] Code review: pkgsend and SVR4 package
conversion enhancements
Date: Thu, 24 Feb 2011 15:27:52 +1300
[snip]
To recap, the main brunt of the change here, is that 'pkgsend
import/generate' will now fail, printing errors when given SVR4 bundles
that contain any class action or install scripts, and will return a '1'
exit code.
'pkgsend import' will abandon the current transaction, though 'generate'
will still emit a list of actions, in spite of the errors.
I've attached before & after output from pkgsend when run on an
interesting package, in case anyone's interested.
Webrevs at:
http://cr.opensolaris.org/~timf/pkgsend-svr4-warnings-webrev-1
http://cr.opensolaris.org/~timf/pkgsend-svr4-warnings-webrev-1-vs-0
cheers,
tim
timf@linn[9073] pkgsend generate SUNWad810/
license copyright license=SUNWad810.copyright path=copyright
dir group=sys mode=0755 owner=root path=kernel
dir group=sys mode=0755 owner=root path=kernel/drv
dir group=sys mode=0755 owner=root path=kernel/drv/amd64
file kernel/drv/amd64/audio810 group=sys mode=0755 owner=root
path=kernel/drv/amd64/audio810
file kernel/drv/audio810 group=sys mode=0755 owner=root path=kernel/drv/audio810
file kernel/drv/audio810.conf group=sys mode=0644 owner=root
path=kernel/drv/audio810.conf
timf@linn[9074] echo $?
0
timf@linn[9075]
timf@linn[9071] pkgsend generate SUNWad810/
legacy arch=i386 category=system desc="SunOS audio device driver for W1100z &
W2100z workstations" hotline="Please contact your local service provider"
name="SUNW W1100z & W2100z Audio Drivers" pkg=SUNWad810
pkg.send.convert.sunw-pkg-hollow=true vendor="Sun Microsystems, Inc."
version=11.10.0,REV=2005.01.21.16.34
set name=pkg.description pkg.send.convert.sunw-pkg-hollow=true value="SunOS
audio device driver for W1100z & W2100z workstations"
set name=pkg.summary pkg.send.convert.sunw-pkg-hollow=true value="SUNW W1100z &
W2100z Audio Drivers"
license copyright license=SUNWad810.copyright path=copyright
pkg.send.convert.sunw-pkg-hollow=true
dir group=sys mode=0755 owner=root path=kernel
pkg.send.convert.sunw-pkg-hollow=true
dir group=sys mode=0755 owner=root path=kernel/drv
pkg.send.convert.sunw-pkg-hollow=true
dir group=sys mode=0755 owner=root path=kernel/drv/amd64
pkg.send.convert.sunw-pkg-hollow=true
file kernel/drv/amd64/audio810 group=sys mode=0755 owner=root
path=kernel/drv/amd64/audio810 pkg.send.convert.sunw-pkg-hollow=true
file kernel/drv/audio810 group=sys mode=0755 owner=root
path=kernel/drv/audio810 pkg.send.convert.sunw-pkg-hollow=true
file kernel/drv/audio810.conf group=sys mode=0644 owner=root
path=kernel/drv/audio810.conf pkg.send.convert.sunw-pkg-hollow=true
pkgsend: generate: ERROR: script present in SUNWad810: preremove
pkgsend: generate: ERROR: script present in SUNWad810: postinstall
timf@linn[9072] echo $?
1
timf@linn[9076]
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
