----- [email protected] wrote:
> Hi all,
>
> Just wondering if anyone has had a chance to look at this code
> review?
>
> I'd like to putback without the fork/exec of pkgmogrify for now if
> possible and address that in a future putback.
>
> The main thing we're missing by not having that, is the ability to
> automatically add actuators to SMF manifests that were previously
> delivered by the "manifest" class. Perhaps running other transforms
> would be good too, but they're a nice-to-have.
>
> Webrevs below.
>
> cheers,
> tim
>
> -------- Forwarded Message --------
> From: Tim Foster <[email protected]>
> To: Edward Pilatowicz <[email protected]>
> Cc: [email protected]
> Subject: Re: [pkg-discuss] Code review: pkgsend and SVR4 package
> conversion enhancements
> Date: Thu, 24 Feb 2011 15:27:52 +1300
>
> [snip]
>
> To recap, the main brunt of the change here, is that 'pkgsend
> import/generate' will now fail, printing errors when given SVR4
> bundles
> that contain any class action or install scripts, and will return a
> '1'
> exit code.
>
> 'pkgsend import' will abandon the current transaction, though
> 'generate'
> will still emit a list of actions, in spite of the errors.
>
> I've attached before & after output from pkgsend when run on an
> interesting package, in case anyone's interested.
>
> Webrevs at:
> http://cr.opensolaris.org/~timf/pkgsend-svr4-warnings-webrev-1
src/man/pkgsend.1.txt:
general: I'm uncertain about the utility of creating actions during import
with pkg.send.convert. It seems useful for generate, but for import it
seems weird to have the published package have that information. I'm aware
that we don't currently differentiate between the two.
line 108: s/set /set /
src/modules/bundle/SolarisPackageDatastreamBundle.py:
line 101: indentation is off one level
line 201: s/file system/file-system/ or s/file system/filesystem/ ?
src/modules/bundle/SolarisPackageDirBundle.py:
line 212: curious, could we use arch to tag the imported package with the
appropriate variant.arch?
line 237: de-indent 4 spaces
src/publish.py:
lines 141-145, 148-149: use named format specifiers
Otherwise, seems fine, but I'm not an SVr4 expert.
-Shawn
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
