Hi Shawn, Thanks for the review. I've addressed the indentation and usage of format specifiers that you pointed out.
On Thu, 2011-03-17 at 17:02 -0700, Shawn Walker wrote: > > Webrevs at: > > http://cr.opensolaris.org/~timf/pkgsend-svr4-warnings-webrev-1 > > src/man/pkgsend.1.txt: > general: I'm uncertain about the utility of creating actions during import > with pkg.send.convert. It seems useful for generate, but for import it > seems weird to have the published package have that information. I'm > aware > that we don't currently differentiate between the two. I agree that it seems weird. Not doing it would mean that we've not done our best to preserve attributes that could contain important information: I took the route of preservation here, over data loss. If there's a consensus that we shouldn't do this, I can certainly separate out the generate and import behaviours to drop these attributes. > line 108: s/set /set / > > src/modules/bundle/SolarisPackageDatastreamBundle.py: > line 101: indentation is off one level > > line 201: s/file system/file-system/ or s/file system/filesystem/ ? Yep, I'll go with "filesystem", thanks. Here's what the our survey said, in case anyone's interested: timf@linn[340] pwd /home/timf/projects/ips/pkg-gate.hg timf@linn[341] find . -exec grep "filesystem" {} + | wc -l 809 timf@linn[342] find . -exec grep "file system" {} + | wc -l 413 timf@linn[343] find . -exec grep "file-system" {} + | wc -l 718 > src/modules/bundle/SolarisPackageDirBundle.py: > line 212: curious, could we use arch to tag the imported package > with the appropriate variant.arch? I wasn't sure on this one. SVR4 packages with an ARCH value of sparc could actually be installed on an i386 system, whereas variant.arch values would prevent this from occurring with the converted IPS package. Back in the dim & distant, I seem to remember needing to install sparc packages on an i386 system while setting something up (was it a diskless install server? I forget the details) It could be that the cases where this was necessary were few & far between, but again I'm erring on the side of caution here by not including variant.arch tags. cheers, tim _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
