Hi there, Just getting back to the sysrepo.py and SMF service-specific aspects that Shawn mentioned as part of his code review,
On Wed, 2011-04-06 at 00:03 -0700, Brock Pytlik wrote: > On 04/ 4/11 02:25 PM, Shawn Walker wrote: > > On 03/30/11 09:36 PM, Brock Pytlik wrote: > >> Here's the system repository work that Tim and I have been working on > >> for quite a while now. > >> http://cr.opensolaris.org/~bpytlik/ips-sysrepo-v1/ > > > I'll let Tim handle these (though I think he's already taken care of them). Yep. > > src/util/apache2/sysrepo/sysrepo_httpd.conf.mako: > > are all the template comments really needed? I've removed some of the initial (misleading) boilerplate at the top of the httpd.conf mako template, but feel that leaving the other standard apache contents in makes it more obvious that this is an Apache configuration file. > > src/sysrepo.py: > > line 102: s/"""/"""\/ will let you move the publisher bit down a line > > > > line 107: it'd be useful for debugging to add 'pkg-server' to the end > > of this and include pkg.VERSION there; just like pkg.depotd > > > > lines 121-124: copy&paste? > > > > line 405: you don't need this if you're passing ignore_errors=True > > > > line 415: the the? Yep, fixed all of the above - thanks. I've also changed sysrepo.py to deliver as /usr/lib/pkg.sysrepo > > src/tests/cli/t_pkg_sysrepo: > > line 948: s/environement/environment/ Fixed that too - thanks. cheers, tim _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
