On 04/11/11 01:33 PM, Edward Pilatowicz wrote:
On Wed, Mar 30, 2011 at 09:36:05PM -0700, Brock Pytlik wrote:
Here's the system repository work that Tim and I have been working
on for quite a while now.
http://cr.opensolaris.org/~bpytlik/ips-sysrepo-v1/
some initial comments below.
ed
---------
src/brand/attach
src/brand/common.ksh
src/brand/pkgcreatezone
- i don't see the zones proxy included in this wad. if that's the case
then i don't think we can remove the publisher syncing logic just yet
because without the zones proxy pkg(1) inside a zone would break
because it wouldn't be able to access the system repo. (have you
tried running the pkg(1) command within a zone with these changes?)
Dan asked me about this to, and while I do remember testing these, I
don't remember to what extent. What I think I did was test that I could
install and update a zone. What I'd like to think I did was then, from
the global zone, use -R to reference the zone created, and make sure the
right things happened. I can't swear with 100% certainty that I did that
though.
Once I get the sysproxy ported to our gate and building, I'll try the
full path. If that's not back when this wad is ready to land, I'll pull
the brand script changes out and put them back after/with the sysproxy wad.
----------
src/brand/attach
src/brand/pkgcreatezone
- why remove the --no-refresh options from the pkg commands executed
here? (to improve scripting performance we explicitly do a full
refresh and then all subsequent operations use --no-refresh.)
I don't remember why right now. I'll look into it and get back to you.
----------
src/brand/attach
- don't we also have to enable the sysrepo service here?
Good point, I'll make that change.
Brock
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
