On Wed, Mar 30, 2011 at 09:36:05PM -0700, Brock Pytlik wrote:
> Here's the system repository work that Tim and I have been working
> on for quite a while now.
> http://cr.opensolaris.org/~bpytlik/ips-sysrepo-v1/
> 

some initial comments below.
ed

---------
src/brand/attach
src/brand/common.ksh
src/brand/pkgcreatezone

- i don't see the zones proxy included in this wad.  if that's the case
  then i don't think we can remove the publisher syncing logic just yet
  because without the zones proxy pkg(1) inside a zone would break
  because it wouldn't be able to access the system repo.  (have you
  tried running the pkg(1) command within a zone with these changes?)

----------
src/brand/attach
src/brand/pkgcreatezone

- why remove the --no-refresh options from the pkg commands executed
  here?  (to improve scripting performance we explicitly do a full
  refresh and then all subsequent operations use --no-refresh.)

----------
src/brand/attach
- don't we also have to enable the sysrepo service here?
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to