On 04/19/11 09:03 PM, Danek Duvall wrote:
Bart Smaalders wrote:

This makes sense to me; I've struggled w/ this before.

Cool.  And with some further validation of the concept from Rich Lowe, I
present the following webrev:

     http://cr.opensolaris.org/~dduvall/pkg-svr4root/

for the following bugs:

     371 Can't import SVr4 packages with absolute paths
     17769 SVR4 conversion assumes BASEDIR is prepended to source
     18154 pkgsend problem with importing a SVr4 directory


src/modules/bundle/SolarisPackageDirBundle.py:
  lines 158-180: These case slook almost identical except for how the
    preserve attribute is handled.  Is there any reason to not combine
    them?

Not easy to add a unit test I'm assuming?

Otherwise, LGTM.

-Shawn
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to