On 04/20/11 01:48 PM, Danek Duvall wrote:
Shawn Walker wrote:

src/modules/bundle/SolarisPackageDirBundle.py:
   lines 158-180: These case slook almost identical except for how the
     preserve attribute is handled.  Is there any reason to not combine
     them?

Laziness.

Not easy to add a unit test I'm assuming?

Not easy, not hard.

Update webrev:

     http://cr.opensolaris.org/~dduvall/pkg-svr4root-2/

Only thing I see missing is something for editable or volatile files. None of the prototypes seem to have such entries. Am I missing something?

That could be a separate bug to fix though...

-Shawn
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to