Shawn Walker wrote:

> src/modules/bundle/SolarisPackageDirBundle.py:
>   lines 158-180: These case slook almost identical except for how the
>     preserve attribute is handled.  Is there any reason to not combine
>     them?

Laziness.

> Not easy to add a unit test I'm assuming?

Not easy, not hard.

Update webrev:

    http://cr.opensolaris.org/~dduvall/pkg-svr4root-2/

Thanks,
Danek
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to