Shawn Walker wrote:
> http://cr.opensolaris.org/~swalker/pkg-overlay/
pkg.5.txt:
- You might note that this is not for ordinary usage, but likely to be
useful for distributions that need to overwrite configuration files
that don't otherwise participate in any self assembly (eg, /etc/motd).
- line 143: "a file" -> "files"
api_errors.py:
- line 702: no need for a backslash
- line 703: this means that the preserve attribute is allowed to conflict
if it's got an overlay attribute?
imageplan.py:
- line 610: Not your code, but shouldn't this just be lstrip("/")?
- line 955: no need for the second argument to get()
- line 956: how about "preserve" in act.attrs?
- line 1108: I'm not thrilled with using a different mechanism for
preventing installation than for preventing removal. Any chance you
could just do the same thing (set the appropriate list element to
None)? I'm not sure if the test for ap on line 1104 is just a
copy/paste from line 1100, but if it's needed, then we're apparently
already setting elements in those lists to None, so you might not need
to make too many more changes.
t_pkg_install.py:
- I think I'd move these tests out into a separate function.
- We might want a test to for when preserve exists in the overlaying
action, but doesn't match what's in the overlaid action (what *is* the
correct behavior there? Perhaps we should require the overlayer to
have no preserve attribute?)
- I don't see a test attempting multiple overlays, even though the
comment very strenuously calls for it.
- line 6608-6609: are these contents calls just old debugging?
- line 6648: "doesn't" -> "don't"
- line 6664: what should succeed here? you're not testing anything
Thanks,
Danek
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
