On 06/08/11 11:34, Danek Duvall wrote:
Shawn Walker wrote:
imageplan.py:
...
- line 1108: I'm not thrilled with using a different mechanism for
preventing installation than for preventing removal. Any chance
you could just do the same thing (set the appropriate list element
to None)? I'm not sure if the test for ap on line 1104 is just a
copy/paste from line 1100, but if it's needed, then we're
apparently already setting elements in those lists to None, so you
might not need to make too many more changes.
I've tried an alternate path here, please carefully look at the
changes as I'm uncertain that I got things right (even though tests
pass...).
I'm assuming that you made pp_needs_trimming a dict with a specific trim
list so that you don't rely on the pkgplan ordering I did when doing this
previously (with the plan_pos dict)? Regardless, I think what you're doing
here is okay.
Exactly.
-Shawn
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
