On 03/ 8/12 10:18 PM, Shawn Walker wrote:
On 03/08/12 02:19, Saurabh Vyas wrote:
On 02/20/12 23:38, Danek Duvall wrote:
...
This seems to be a difference between looking at an image without any
packages installed and one with, as if I install a package into my test
image first, I get the r.origins stack trace.
I think maybe get_highest_ranked_publisher() should always return
None if
there are no configured publishers, regardless of whether there are any
installed packages, as there's no sense of publisher ranking if there
is no
publisher configuration.
....
NOTE : I remove one test inside : test_publisher_apis (api/t_api.py)
as now get_highest_ranked_publisher() returns 'None' when there are no
configured publishers.
Please don't make this change. I specifically had
get_highest_ranked_publisher() return the first publisher because of an
issue with packagemanager. That's also why I had the unit test for it.
I believe this will break search functionality in the packagemanager.
Thanks for this input Shawn.
In this case, I will move back to previous approach i.e :
@@ -4557,6 +4557,11 @@
msg(fmt % tuple(hdrs))
for p in pubs:
+ # We can skip further processing if
+ # there are no configured publishers
+ if p.repository is None:
+ continue
+
# Store all our publisher related data in
Tested both scenarios again :
- No publisher configured for the current image
root@onnv175b-nd:~# pkg publisher -P
PUBLISHER TYPE STATUS URI
- Image with No package
root@onnv175b-nd:~# pkg -R /var/tmp/img publisher -P
PUBLISHER TYPE STATUS URI
works as expected
Created webrev again :
https://cr.opensolaris.org/action/browse/pkg/saurabhv/CR-7141684-rev4/webrev/
Please let me know if this seems fine.
Thanks,
~Saurabh
-Shawn
--
Saurabh Vyas
Solaris Install Group,
Revenue Product Engineering (RPE), Systems |Bangalore |
Green Oracle <http://www.oracle.com/commitment> Oracle is committed to
developing practices and products that help protect the environment
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
