Thanks Shawn for quick response, more inline......
On 03/21/12 08:13 PM, Shawn Walker wrote:
On 03/21/12 04:24, Saurabh Vyas wrote:
...
...
I have made the changes as suggested, updated webrev :
https://cr.opensolaris.org/action/browse/pkg/saurabhv/CR-7141684-rev5/webrev/
src/tests/cli/t_pkg_publisher.py:
lines 435-441: This is indented one level too far, so it's currently
being treated as a nested function of test_publisher_properties.
De-indent this and re-run just this test to verify.
Thanks for catching this, I have corrected the indentation.
Re-ran the test, runs successfully.
Update webrev too :
https://cr.opensolaris.org/action/browse/pkg/saurabhv/CR-7141684-rev6/webrev/
Add a test case to src/tests/cli/t_pkg_publisher.py.
I have added test case for this bug, ran the test suite (runs fine).
Just to be sure I just ran the test case I added on the tip of gate
without this fix, and got the traceback.
That's the correct way to test.
Thanks for confirming this.....
Please let me know your thoughts / comments ......
Since I helped you write this, I can't really be your final reviewer.
Someone else will need to review this.
Please if some one else (apart from Shawn) can provide their review
comments for this fix.
Thanks again,
Saurabh
-Shawn
--
Saurabh Vyas
Solaris Install Group,
Revenue Product Engineering (RPE), Systems |Bangalore |
Green Oracle <http://www.oracle.com/commitment> Oracle is committed to
developing practices and products that help protect the environment
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
