On 03/21/12 01:43, Shawn Walker wrote:
On 03/20/12 04:32, Saurabh Vyas wrote:
Hi All,
Another reminder, please if someone can provide inputs on this fix.
More details in mail below........
for quick ref, webrev location :
https://cr.opensolaris.org/action/browse/pkg/saurabhv/CR-7141684-rev4/webrev/
So this isn't the right fix for a few reasons:
* it will show the publisher returned by
get_highest_ranked_publisher() even if that publisher is not
explicitly configured
* it potentially will not show publishers that do not have configured
origins or mirrors
Thanks alot Shawn for these inputs.
* this change needs a test case
...
I have made the changes as suggested, updated webrev :
https://cr.opensolaris.org/action/browse/pkg/saurabhv/CR-7141684-rev5/webrev/
Add a test case to src/tests/cli/t_pkg_publisher.py.
I have added test case for this bug, ran the test suite (runs fine).
Just to be sure I just ran the test case I added on the tip of gate
without this fix, and got the traceback.
Please let me know your thoughts / comments ......
Thanks again,
Saurabh
I think the above will get the desired result.
-Shawn
--
Saurabh Vyas
Solaris Install Group,
Revenue Product Engineering (RPE), Systems
ORACLE India | Off Langford Road | Bangalore | 560025
|Bangalore |
Green Oracle <http://www.oracle.com/commitment> Oracle is committed to
developing practices and products that help protect the environment
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
