On 03/27/12 08:12, Bart Smaalders wrote:
On 03/22/12 05:18, Abhinandan Ekande wrote:
Folks,
Please review fix for CR :
7140680 "pkg history" does not work in some localized locales
webrev :
https://cr.opensolaris.org/action/browse/pkg/saurabhv/7140680-rev1/webrev/
Why did this part of pkg have problems w/ encodings, but no other? Are
there more bugs related to this problem?
This is one of the few places where unicode objects are actually
encountered.
However, this is not the only place with a potential issue.
We need a custom log formatter for the logging module usage to deal with
this [1], and msg() and emsg() in pkg.misc likely need fixing as well.
Python's encoding behaviour has unfortunately changed multiple times
since 2.4 and even during the lifetime of 2.6.
What's worse is that in the case that pygtk or pango are imported (like
the packagemanager does), Python's default encoding is changed to the
current locale so this is unnecessary [2]. (Although it shouldn't hurt
from what I can tell in that case.)
-Shawn
[1]
http://tony.czechit.net/2009/02/unicode-support-for-pythons-logging-library/
[2] https://bugzilla.gnome.org/show_bug.cgi?id=132040
_______________________________________________
pkg-discuss mailing list
pkg-discuss@opensolaris.org
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
