Abhinandan Ekande wrote:

> https://cr.opensolaris.org/action/browse/pkg/ae112802/7140680-rev3/webrev/

Sorry for the long delay.

Change looks good, though I'd add an assertion that unicode_list isn't
empty, with an explanation of the failure.  Something like

    self.assert_(unicode_list, "You must have one of the following locales "
        "installed for this test to succeed: " + ", ".join(unicode_locales))

And on line 583, in the dictionary, don't put a space before the colon.

Thanks,
Danek
_______________________________________________
pkg-discuss mailing list
pkg-discuss@opensolaris.org
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to