Thanks Danek for review.
On 04/18/12 02:25, Danek Duvall wrote:
t_pkg_history.py:
- Where do we get the localizations for use during the test suite?
/usr/share/locale, or from the gate or proto area somewhere? (Would
this test fail if I didn't have the Chinese locale installed?)
Good point. I have modified the code to get locale for which
"pkg history" command fails from locale command.
- line 574: no need for the second argument. Though I think I'd rather
see you add support for cmdline_run()'s "env_arg" argument to pkg()
instead of setting the environment globally.
- line 577: no need for "exit=0"; that's the default
Incorporated above comments too.
The updated webrev is at :
https://cr.opensolaris.org/action/browse/pkg/ae112802/7140680-rev3/webrev/
Ran the complete test suite, no failures reported.
Abhi.
Also, please use double quotes instead of single quotes unless there's a
good reason to do otherwise.
Thanks,
Danek
--
Oracle
Abhinandan Ekande
Solaris Install,
Revenue Product Engineering (RPE), Systems
Phone: +91 8041847267 | Fax: +91 80 22231794 | Mobile: +91 9632144088
ORACLE India | Off Langford Road | Bangalore | 560025
Green Oracle <http://www.oracle.com/commitment> Oracle is committed to
developing practices and products that help protect the environment
_______________________________________________
pkg-discuss mailing list
pkg-discuss@opensolaris.org
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
