On 02/ 9/13 08:12 AM, Shawn Walker wrote:
On 02/07/13 19:15, Tim Foster wrote:
"Removing metadata 1/100"
The problem with that idea is that we don't know how much metadata there
is to remove and since we're not actually removing the metadata
piece-by-piece (we use rmtree) we can't provide meaningful progress for
each metadata item as it is removed.
We do have some visibility into what we're removing, in some parts of
the code[1] we're iterating over several directories looking for
candidate directories to remove, calling shutil.rmtree when we need to.
Some shutil.rmtree calls will take longer than others, I'd rather a
counter telling me how many directory-trees of content to consider
removing are left, than just a random spinning '|/-\|-\'.
You're right in that when we're removing an entire publisher (line
3422), we've no visibility into the metadata removal, but not with the
rest of the code (perhaps in that case, metadata removal is so fast it's
not worth considering emitting progress?)
cheers
tim
[1]
http://src.opensolaris.org/source/xref/pkg/gate/src/modules/client/image.py#3424
ish
_______________________________________________
pkg-discuss mailing list
pkg-discuss@opensolaris.org
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
