On 02/19/13 00:09, Thejaswini wrote:
Hi,
I have made the suggested changes and uploaded the webrev
@
https://cr.opensolaris.org/action/browse/pkg/tk241774/15771543-rev02/webrev/.
1. "15769004 pkg unset-publisher could use a progress tracker"
The output now looks like:
root@S12_13:~# pkg unset-publisher solaris
PHASE ITEMS
Updating package cache 1/1
So one thing I noticed is that there is a distinct disadvantage to doing
this progress tracking in image.py; notably that simply doing a
'set-publisher' now outputs the progress message for updating the
package cache. That is not something we want.
So instead of placing the progress tracking in modules/client/image.py,
I think we should consider adding it to client.py in publisher_unset.
And instead of settings 'goal=1', we can also set goal=len(args) which
will be nice.
I didn't test this earlier, so I apologise, and because I suggested the
change, I can't "review" the change for modules/client/iamge.py.
I would like someone else's feedback on that change if possible.
-Shawn
_______________________________________________
pkg-discuss mailing list
pkg-discuss@opensolaris.org
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
