Thanks Shawn, Tim.
Please find my reply inlined.
On 02/28/13 02:49, Shawn Walker wrote:
On 02/27/13 13:11, Tim Foster wrote:
On 02/22/13 06:42 PM, Thejaswini wrote:
On 02/21/13 22:00, Shawn Walker wrote:
On 02/20/13 23:56, Thejaswini wrote:
The new rev 03 webrev is @
https://cr.opensolaris.org/action/browse/pkg/tk241774/15771543-rev03/
This includes:
For bug "15769004 pkg unset-publisher could use a progress tracker"
- As suggested by Shawn, I have added the progress tracker in
client.py
Again, I cannot be your final reviewer, but I think you want the call
to job_add_progress *after* the call to remove_publisher() since you
haven't actually made any progress before that point.
I agree - that would be a useful change to make.
remove_publisher() is the function which takes long. If
job_add_progress
is called after this function then the progress tracker would not
appear
until remove_publisher() returns.
And then again as reported the command would sit displaying nothing.
Yep.
Is there a way where the tracker could display
/Updating package cache *0/*1 /before calling//remove_publisher() and
/Updating package cache *1/*1/ after remove_publisher() returns.
I'm surprised it doesn't do that already -- I'd have thought that by
calling progtrack.job_start(...) that we'd print the first line above,
then once you've actually made progress, it prints the second.
No it does not print anything after calling job_start()
I suspect this is because the JOB stuff is usually called within the
context of image planning.
But it still seems strange as the JOB interfaces appear to be usable
outside of that context.
My only concern here is that we're able to provide progress output
here without adding new interfaces; that makes this suitable for
backport if desired and keeps us from having to coordinate
cross-consolidation.
I see in image.py that job_add_progress() is called before the action
is actually performed.
Looking at the definition of job_start(), it does not seem to perform
any printing operations.
I have made changes in job_start() so that it prints 0/1.
Webrev is @
https://cr.opensolaris.org/action/browse/pkg/tk241774/15771543-rev04/webrev/
- Thejaswini K.
-Shawn
_______________________________________________
pkg-discuss mailing list
pkg-discuss@opensolaris.org
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
