On 02/20/13 14:51, Erik Trauschke wrote:
...
incremental:
https://cr.opensolaris.org/action/browse/pkg/erisch/16193298_1-2/webrev/

src/tests/cli/t_pkgrecv.py:
lines 824-834: nitty, but for the cases where you have a line continuation, can you indent them 4 spaces (828, 830)? same applies to other files where you have arg_dict.

general: the "user=sys" thing you added isn't portable across other platforms we might run the test suite on; you shouldn't need it anyway; just set su_wrap=True on the options where you want to test permissions access. You should be able to revert your user changes to pkg5unittest.py after trying that.

Otherwise, seems right.

-Shawn
_______________________________________________
pkg-discuss mailing list
pkg-discuss@opensolaris.org
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to