On 02/20/13 16:04, Erik Trauschke wrote:
On 02/20/13 03:51 PM, Shawn Walker wrote:
On 02/20/13 15:40, Erik Trauschke wrote:
On 02/20/13 03:34 PM, Shawn Walker wrote:
On 02/20/13 14:51, Erik Trauschke wrote:
...
incremental:
https://cr.opensolaris.org/action/browse/pkg/erisch/16193298_1-2/webrev/
src/tests/cli/t_pkgrecv.py:
lines 824-834: nitty, but for the cases where you have a line
continuation, can you indent them 4 spaces (828, 830)? same applies to
other files where you have arg_dict.
then it's indented 8 spaces from the original start of continuation.
That seems wrong to me. I know it looks stupid, though.
general: the "user=sys" thing you added isn't portable across other
platforms we might run the test suite on; you shouldn't need it anyway;
just set su_wrap=True on the options where you want to test permissions
access. You should be able to revert your user changes to
pkg5unittest.py after trying that.
I looked into the su_wrap thing. It seems that won't work if you run the
test bench as root and not just with sudo. I tried to find something
that works in any case. I thought about going through /etc/passwd to
find the first user with a shell, but figured nobody is running the test
bench on anything other than solaris.
If somebody runs the suite as real root, the test won't be valid (it
will still fail because the actual file is empty but it fails for the
wrong reason).
su_wrap=True should work just fine unless we've done something terribly
wrong; that's specifically what we use for permission tests in other
parts of the test suite. See if you can figure out why it doesn't work
for your case.
Oh, I see. Looking at it again it does the same thing I'm doing, just
using nobody or noaccess as the user. Not sure if that is any more
platform-independent then any other user, though.
nobody and noaccess are translatable to most unix-like platforms.
-Shawn
_______________________________________________
pkg-discuss mailing list
pkg-discuss@opensolaris.org
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
