On 02/20/13 15:59, Erik Trauschke wrote:
On 02/20/13 03:40 PM, Erik Trauschke wrote:
On 02/20/13 03:34 PM, Shawn Walker wrote:
On 02/20/13 14:51, Erik Trauschke wrote:
...
incremental:
https://cr.opensolaris.org/action/browse/pkg/erisch/16193298_1-2/webrev/
src/tests/cli/t_pkgrecv.py:
lines 824-834: nitty, but for the cases where you have a line
continuation, can you indent them 4 spaces (828, 830)? same applies to
other files where you have arg_dict.
then it's indented 8 spaces from the original start of continuation.
That seems wrong to me. I know it looks stupid, though.
Talking to some other people it seems we already have code in the gate
which is indented that way. But I've never seen it in any language and
it still feels odd to me. However, if you feel strongly about it I go
ahead and indent this way.
The point is readability, so that's the focus instead of strict
adherence to formatting rules.
-Shawn
_______________________________________________
pkg-discuss mailing list
pkg-discuss@opensolaris.org
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
