Your message dated Thu, 30 Jul 2015 21:40:17 +0000 with message-id <e1zkvyn-0002c3...@franck.debian.org> and subject line Bug#794047: fixed in pyspatialite 3.0.1-9 has caused the Debian Bug report #794047, regarding pyspatialite: distro patch causes misbuild on 64-bit archs to be marked as done.
This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the Bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact ow...@bugs.debian.org immediately.) -- 794047: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=794047 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems
--- Begin Message ---Package: pyspatialite Version: 3.0.1-8 Severity: serious Tags: patch User: ubuntu-de...@lists.ubuntu.com Usertags: origin-ubuntu wily ubuntu-patch pyspatialite is currently misbuilt on 64-bit architectures in Debian testing and unstable, because of a distro patch that causes /usr/include/spatialite to be added to the header search path. libspatialite-dev ships both a /usr/include/spatialite.h and a /usr/include/spatialite/spatialite.h, and the first one is the correct one. Without the correct function types, this results in the compiler truncating pointers along its way; e.g., from <https://buildd.debian.org/status/fetch.php?pkg=pyspatialite&arch=arm64&ver=3.0.1-8&stamp=1436875015>: aarch64-linux-gnu-gcc -pthread -DNDEBUG -g -fwrapv -O2 -Wall -Wstrict-prototypes -fno-strict-aliasing -g -O2 -fstack-protector-strong -Wformat -Werror=format-security -D_FORTIFY_SOURCE=2 -fPIC -DMODULE_NAME="spatialite.dbapi2" -DVERSION="3.0.1" -DSQLITE_ENABLE_FTS3=1 -DSQLITE_ENABLE_RTREE=1 -DSQLITE_ENABLE_COLUMN_METADATA=1 -DOMIT_FREEXL=1 -DSPATIALITE_HAS_INIT_EX=1 -I/usr/include -I/usr/include/spatialite -I/usr/include/python2.7 -c src/connection.c -o build/temp.linux-aarch64-2.7/src/connection.o src/connection.c: In function 'pysqlite_connection_init': src/connection.c:110:9: warning: implicit declaration of function 'spatialite_alloc_connection' [-Wimplicit-function-declaration] self->slconn = spatialite_alloc_connection(); ^ src/connection.c:110:22: warning: assignment makes pointer from integer without a cast self->slconn = spatialite_alloc_connection(); ^ This doesn't get caught by the Debian buildds, but in Ubuntu this is treated as a fatal error as this is a known misbuild that won't work at all on some 64-bit architectures and will fail randomly at runtime on others. The one-liner fix has been applied to Ubuntu with the following changelog: * debian/patches/00-fix_build.patch: don't add /usr/include/spatialite to the search path. This is a wrong fix which causes /usr/include/spatialite/spatialite.h to be found instead of /usr/include/spatialite.h, resulting in a misbuild on 64-bit archs. Thanks for considering the patch. -- Steve Langasek Give me a lever long enough and a Free OS Debian Developer to set it on, and I can move the world. Ubuntu Developer http://www.debian.org/ slanga...@ubuntu.com vor...@debian.orgdiff -Nru pyspatialite-3.0.1/debian/patches/00-fix_build.patch pyspatialite-3.0.1/debian/patches/00-fix_build.patch --- pyspatialite-3.0.1/debian/patches/00-fix_build.patch 2015-06-27 15:57:24.000000000 -0700 +++ pyspatialite-3.0.1/debian/patches/00-fix_build.patch 2015-07-29 20:57:42.000000000 -0700 @@ -7,9 +7,11 @@ setup.py | 21 ++++++++++++--------- 1 file changed, 12 insertions(+), 9 deletions(-) ---- a/setup.py -+++ b/setup.py -@@ -44,7 +44,7 @@ sources = ["src/module.c", "src/connecti +Index: pyspatialite-3.0.1/setup.py +=================================================================== +--- pyspatialite-3.0.1.orig/setup.py ++++ pyspatialite-3.0.1/setup.py +@@ -44,7 +44,7 @@ include_dirs = [] library_dirs = [] @@ -18,7 +20,7 @@ runtime_library_dirs = [] extra_objects = [] define_macros = [] -@@ -113,24 +113,27 @@ def get_amalgamation(): +@@ -113,24 +113,26 @@ class MyBuildExt(build_ext): def build_extension(self, ext): @@ -50,7 +52,6 @@ + #ext.sources.append(os.path.join(AMALGAMATION_ROOT, "sqlite3.c")) + #ext.sources.append(os.path.join(AMALGAMATION_ROOT, "spatialite.c")) + #ext.include_dirs.append(AMALGAMATION_ROOT) -+ ext.include_dirs.append("/usr/include/spatialite") build_ext.build_extension(self, ext)
--- End Message ---
--- Begin Message ---Source: pyspatialite Source-Version: 3.0.1-9 We believe that the bug you reported is fixed in the latest version of pyspatialite, which is due to be installed in the Debian FTP archive. A summary of the changes between this version and the previous one is attached. Thank you for reporting the bug, which will now be closed. If you have further comments please address them to 794...@bugs.debian.org, and the maintainer will reopen the bug report if appropriate. Debian distribution maintenance software pp. Bas Couwenberg <sebas...@debian.org> (supplier of updated pyspatialite package) (This message was generated automatically at their request; if you believe that there is a problem with it please contact the archive administrators by mailing ftpmas...@ftp-master.debian.org) -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512 Format: 1.8 Date: Thu, 30 Jul 2015 14:14:19 +0200 Source: pyspatialite Binary: python-pyspatialite Architecture: source amd64 Version: 3.0.1-9 Distribution: unstable Urgency: medium Maintainer: Debian GIS Project <pkg-grass-devel@lists.alioth.debian.org> Changed-By: Bas Couwenberg <sebas...@debian.org> Description: python-pyspatialite - Python interface to Spatialite Closes: 794047 Changes: pyspatialite (3.0.1-9) unstable; urgency=medium . * Apply patch from Ubuntu to fix misbuild on 64-bit archs. Thanks to Steve Langasek for forwarding the patch. (closes: #794047) * Use multi-line uscan options in watch file. Checksums-Sha1: 73def37e75df0fecfc363629ebbc16765ba5b2ae 2084 pyspatialite_3.0.1-9.dsc f1f7837e2f3b8bd18d1c8564c73173a3650e6d19 4664 pyspatialite_3.0.1-9.debian.tar.xz 675c992fc868f189bea3e5c2e5f22da12dee3d5b 30204 python-pyspatialite_3.0.1-9_amd64.deb Checksums-Sha256: 6cbc8d9c9126477e28aef91ca40f09cf5c90064d4a1ec746f9bf0e4c6b430d39 2084 pyspatialite_3.0.1-9.dsc 7099e837640b3f7ae7ed89a4e3e812dda641c6cebf312c233c183bba12ffad7e 4664 pyspatialite_3.0.1-9.debian.tar.xz 543d61d6f0b1c4215c29abb0c21ef298ca6c761c5c8f41740f5de9d0fc14a480 30204 python-pyspatialite_3.0.1-9_amd64.deb Files: 3fe6f8a5af31a1e93c737e549ff1482a 2084 python optional pyspatialite_3.0.1-9.dsc c298639846b14f270a7bd782a03382be 4664 python optional pyspatialite_3.0.1-9.debian.tar.xz ff76ff9dd422e4684d284bd3040306c3 30204 python optional python-pyspatialite_3.0.1-9_amd64.deb -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBCgAGBQJVuhv6AAoJEGdQ8QrojUrx5oUQAJx4waPLkgfwh+EwEoirjNmo CxCd8Dd6eDZtDIBGRNJXvDuwYyvJpR7004PZPMSLm1YWNQSzA3ehKnU8sDYr8kv/ okx/6LLDCxwHzp6Q4+Da4bj/HLFaEMFQIO9tALIvEpayujYefVmA3RVz4qU0biI4 tZBmKGLT7IoE5EGKc3cvl7XB6V0k8HCv2qrZQDDD5mXe7DYe6q6K0a2BWjRC/nsR RmYBIiDw6jGGSTB9P2MnTOH8MBOSlSOgWrQCiaf3s2HMAXsdnOfe2xzCseoDZyZ8 R804wBnVkvZPoaxyoIsRtNQQSKqMFqrXDfPKk87dVcrRmt0bJVgn1w9W4uwXYfUH vNZn2oAUN0bntlp6PgrsiOJSfXcK+L6atWAzPE++T9NFItuFLRMcf358f/51Jnrf K33m1y8QUB9wbuVrAoQZjYJ/PjS1JKnf0tSDxxCMpXypN3bS7o0/hTdYO1OXxeEd iG65BxNjNB0/98BK0jP0LUS3bABZoJ37inCXkmMZWRCzg1zD0CZlnH7my3oTwvgC ILvaN/xGVleA0Q5pejt8GQZ+2WrNOhKHDsxZJFTm0W8uNu2uMvv9NwHXVD/qJ0Bv nd7SU80OwR/vqoni41uH6EfUnnq458HPgl6rBM9yzmG+V9WvJIkSTaOtWiE1ZZvJ WcdjZfAMgYBaxI7KXjMH =24Qj -----END PGP SIGNATURE-----
--- End Message ---
_______________________________________________ Pkg-grass-devel mailing list Pkg-grass-devel@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-grass-devel
