On 21.01.2014 14:44, Gergely Nagy wrote: > Dear maintainer, > > While processing your upload of relaxngcc 1.12-1, I noticed the > following things about the packaging: > > - The source tarball has been repacked, but this is not documented > anywhere, and the only sign of it is the get-orig-targz target in > debian/rules. Please document this in the debian/copyright file. > Explaining why the repacking was done and what is removed would > also be nice to see documented in debian/README.source, not just as > comments in debian/rules.
Pretty much all the java packages I've dealt with repack the source, filtering .class and .jar files and whatnot. Now I see though that it doesn't have README.source at all, I'll add that to git. > - src/relaxngcc/javabody/JavaBodyParser.jj does not appear to be > under the Apache-1.1 license, but what exactly it is under, is > unclear to me. This should be clarified. Looks like it's from javacc: examples/JavaGrammars/Java1.1.jj and modified for this project. The original file is under BSD-3-clause. > - There are a couple of files in the source that have comments like: > /* this file is generated by RelaxNGCC */ > > Are these files rebuildable? (Sadly, my Java build system knowledge > is not enough to determine this on my own) Not sure, no idea where they were generated from.. I'll see if they are needed at all. > None of these warrant a reject, but I would like to see them > clarified, if I'm to let the package through NEW. If you want to > correct them, and reupload, instead of fixing them in a future > version, that is also an option. I will reject the current version > from NEW then, and you can reupload after. If it's ok I'll push updates to git and get -2 uploaded soon enough that should cover all the above. Getting -1 through NEW would still be nice :) -- t __ This is the maintainer address of Debian's Java team <http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-java-maintainers>. Please use debian-j...@lists.debian.org for discussions and questions.