Am 03.07.2017 um 10:52 schrieb Emmanuel Bourg:
> Le 3/07/2017 à 10:02, Markus Koschany a écrit :
> 
>> shouldn't we be more consistent with the other helpers and choose UTF-8
>> too? I'm not sure anymore which helper has already been fixed (I
>> remember Kai-Chung sent in a patch for Gradle). I'm glad to help with
>> this if there is more work required.
> 
> maven-debian-helper at least doesn't have a default encoding, each
> project defines its encoding by setting the project.build.sourceEncoding
> property.
> 
> I'd prefer using UTF-8 too, but it will trigger unmappable character
> errors on many packages (it does with libidw-java for example). Using
> ISO-8859-1 is roughly equivalent to the behavior we had before changing
> the language level to 1.7. Since this mostly affects comments in the
> code it isn't very important.
> 
> I'm fine if someone wants to use UTF-8, but he has to be prepared to
> also fix the packages built with jh_build.

I'm in favor of switching everything to UTF-8 by default. Specifying the
sourceEncoding per package should be a last resort then. Most of the
unmappable character errors I had in my packages came from using ASCII
as the default. Since then I switched countless packages manually to
UTF-8 or ISO-8859-1 and this shouldn't be necessary. I agree that some
packages will FTBFS but also think that the switch to UTF-8 is
beneficial in the long run.

Don't we have a way to say javahelper and maven-debian-helper default to
UTF-8 but existing overrides like project.build.sourceEncoding (Maven)
or export _JAVA_OPTIONS (javahelper) still continue to work and take
precedence over them?

Markus



Attachment: signature.asc
Description: OpenPGP digital signature

__
This is the maintainer address of Debian's Java team
<http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-java-maintainers>. 
Please use
debian-j...@lists.debian.org for discussions and questions.

Reply via email to