On Thu, Sep 02, 2010 at 09:36:10AM +0200, Roman Haefeli wrote:
On Thu, 2010-09-02 at 01:07 -0400, Hans-Christoph Steiner wrote:
Looks pretty good to me, but I'm just learning myself :)

Thanks for having a look.
One thing I like to mention: The upstream sources come with a Makefile
based on a apparently old Makefile template for libdirs. It was pretty
broken and created superfluous directories in debian/. I copied over the
current template, adapted it and applied it as a quilt patch. Is that
the proper way to do it?

Sounds sane to me.

Please consider adding DEP3 headers to the patch if you haven't already. More info here: http://dep.debian.net/deps/dep3/

And be nice and pass on the patch to upstream.

Kind regards,

 - Jonas

 * Jonas Smedegaard - idealist & Internet-arkitekt
 * Tlf.: +45 40843136  Website: http://dr.jones.dk/

 [x] quote me freely  [ ] ask before reusing  [ ] keep private

Attachment: signature.asc
Description: Digital signature

pkg-multimedia-maintainers mailing list

Reply via email to