pgkos added a comment.

  Things look bad when a bitmap icon appears in the tray... (e.g. Remmina) It 
seems `roundToIconSize` is necessary for bitmap icons.
  
  I think I am going to abandon this patch, as the necessary changes are simply 
too big:
  
  - all references to `marginHints` in the systemtray should be removed, and 
`spacing` used instead
  - `Units::roundToIconSize` has to be changed so it works on real pixels and 
not on density-independent pixels - now it breaks down on HiDPI screens
  
  I think no of these two changes are going to be accepted, unless someone 
knows why exactly these two things are implemented the current way.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D10487

To: pgkos, #plasma_workspaces, davidedmundson
Cc: anthonyfieroni, ngraham, davidedmundson, plasma-devel, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

Reply via email to