ngraham requested changes to this revision.
ngraham added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> SettingsBase.cpp:159
>      helpActionMenu->setMenu( dynamic_cast<QMenu*>( 
> factory()->container(QStringLiteral("help"), this) ) );
> -    setMinimumSize(620,430);
>      toolBar()->setMovable(false); // We don't allow any changes

Don't remove this, or else it becomes possible to resize the window to 
absurdly, unusably small sizes. The value could be changed, but we shouldn't 
remove this entirely.

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D12252

To: sharvey, ngraham, mart
Cc: zzag, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

Reply via email to