kossebau added inline comments.

INLINE COMMENTS

> ColorPicker.qml:34
> +
> +    QtDialogs.ColorDialog {
> +        id: colorDialog

Open question to developers:
how expensive is it to have an instance of ColorDialog per button, instead of 
sharing one over all buttons?

That's where the code for both ColorButtons here is yet to be aligned.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D12318

To: kossebau, #plasma, #vdg
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

Reply via email to