davidedmundson added a comment.

  There's ColorButton  
(https://api.kde.org/frameworks/kdeclarative/html/classColorButton.html) inside 
kquickcontrols
  
  Can't we use that?

INLINE COMMENTS

> kossebau wrote in ColorPicker.qml:34
> Open question to developers:
> how expensive is it to have an instance of ColorDialog per button, instead of 
> sharing one over all buttons?
> 
> That's where the code for both ColorButtons here is yet to be aligned.

It's open source, you can see what Qt Dialogs does internally.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D12318

To: kossebau, #plasma, #vdg
Cc: davidedmundson, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

Reply via email to