kossebau added a comment.
In D12318#249050 <https://phabricator.kde.org/D12318#249050>, @davidedmundson wrote: > There's ColorButton (https://api.kde.org/frameworks/kdeclarative/html/classColorButton.html) inside kquickcontrols > > Can't we use that? Ah, I had only grepped for ColorDialog and before also only seen that custom code in the image wallpaper config. From quick testing that one works as well, and is used in Fifteenpuzzle config UI. Though not anywhere else. Leaves me slightly puzzled why nothing else has used it before and instead did own creations? With KQuickControls.ColorButton: F5811924: Screenshot_20180418_205933.png <https://phabricator.kde.org/F5811924> F5811928: Screenshot_20180418_205912.png <https://phabricator.kde.org/F5811928> F5811925: Screenshot_20180418_210015.png <https://phabricator.kde.org/F5811925> Would do similar patches for image wallpaper & similar as well if this one is okayed. REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D12318 To: kossebau, #plasma, #vdg Cc: davidedmundson, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
