I like all this. I don't like forks and used to have branches on main repo - not recommended. >
> Indeed. The "upstream" repo shouldn't be used as a workspace for ongoing work. Your workspace is your fork. Also, this is free to choose from. If one wants to work with a fork (e.g. to stash WIP), then this is perfectly valid. IMO working with forks is easier to grasp for the casual contributor/committer since creating PR's can be done from the Github UI and creating branches is not allowed for contributors. > Indeed. The "upstream" repo shouldn't be used as a workspace for ongoing work. Your workspace is your fork. Are local branches (i.e. branches in the main repo) needed in your workspace-only workflow? On Thu, 24 Mar 2022 at 13:10, Mickael Istria <mist...@redhat.com> wrote: > Hi, > > I'm putting a few answers here, but those could go to the document pointed > out by Sravan (which by the way could be renamed to CONTRIBUTING.md) > > >> I don't like forks and used to have branches on main repo - not >> recommended. >> > > Indeed. The "upstream" repo shouldn't be used as a workspace for ongoing > work. Your workspace is your fork. > > I don't like multiple commits in one PR and always use amend/force push - >> not recommended. >> > > That's *not* not recommended. It's just something that is up to the > submitter, we shouldn't recommend anything here and let contributors build > the workflow they prefer. > What needs to be recommended is how we merge and keep a meaningful > granularity for commits, not how contributors submit their PRs. > > >> I never use command line git and do everything from Eclipse - but some >> recommended to use git CLI. >> > > What typical commands do you have in mind? GitHub really is standard Git > when it comes to push/fetch, the only thing to know is that reference to > fetch/merge a PR is `pulls/123/head`, so there is no Git fanciness needed > and EGit can be used for most operations. The only operation needed is the > creation of a pull request and its review, that usually happens via an > external tool (eg GitHub website). > > >> Egit support missing or not - not clear. What exactly is missing, why CLI >> is needed? >> > > There is decent support for GitHub in EGit. If anything is missing, it > should be reported to EGit. > > >> It is unclear / undocumented how to *properly* refer to bugs in commits >> (full url? repo-name/id? just id?). >> It is unclear if we should now use dedicated github bug trackers *per >> repository* to report bugs, or will be there some higher level bug tracker >> for entire platform organization? >> > > I believe that is still to be determined, as we're growing collective > experience here. > > >> Once the PR is created, I see that builds somehow triggered in equinox, >> but I neither get mails that they are stared nor they are finished. > > > That's an interesting thought. I don't know whether there is some option > to allow email notifications for votes. > > _______________________________________________ > platform-dev mailing list > platform-dev@eclipse.org > To unsubscribe from this list, visit > https://www.eclipse.org/mailman/listinfo/platform-dev >
_______________________________________________ platform-dev mailing list platform-dev@eclipse.org To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/platform-dev
