Looks good. Thanks for the nice work. -nate
On Fri, Mar 28, 2008 at 2:43 AM, Jordi Polo <[EMAIL PROTECTED]> wrote: > > It looks perfect to me, > If Nate don't complain in 3 or 4 days, I'll apply it. > Thanks a lot! > > > > > On Fri, Mar 28, 2008 at 7:06 AM, David Olsen <[EMAIL PROTECTED]> wrote: > > > I've updated the patch. This time it installs all the headers > > belonging to the gazebo server. A nice side effect is that it's > > against the latest again so hopefully it shouldn't be any trouble to > > apply. Is there anything else that needs to be done? > > > > Thanks, > > David > > > > > > > > > > On 10/03/2008, David Olsen <[EMAIL PROTECTED]> wrote: > > > > Why install Joint.hh and HingeJoint.hh and not the other? > > > > > > I just installed what I needed for the plugin controller I'm working > > > on. I'm not sure what exactly should be installed (everything?). At > > > the moment I think the majority of the headers aren't. It seems like a > > > separate issue, perhaps it merits a patch of it's own? You have a > > > point, in that I should probably install all the headers or none of > > > them to keep things tidy. > > > > > > > I guess the functionality can be extended to arbitrary plugins and > not only > > > > controllers. > > > > > > I assume it would be fairly simple to do, but the plugin loading code > > > should be moved out of the controller factory in that case. I haven't > > > looked at plugins for anything else yet. > > > > > > > Also, why did you need this functionality in the first place? > > > > > > The same reason player and stage have plugins. It's easier to develop > > > a model outside the source tree up until it's ready to be released. It > > > also saves you from building the whole of gazebo every time you modify > > > a WIP controller. > > > > > > Thanks, > > > David > > > > > > > > > > > On Sat, Mar 8, 2008 at 3:01 PM, David Olsen <[EMAIL PROTECTED]> > wrote: > > > > > > > > > Hi, > > > > > > > > > > I just submitted a patch that adds plugin controller functionality > to > > > > > gazebo. > > > > > > > > > > > > > > > > http://sourceforge.net/tracker/index.php?func=detail&aid=1909966&group_id=42445&atid=433166 > > > > > > > > > > Since this is my first patch, I'd appreciate any comments people > have > > > > > on it. Is there anything I need to change to make it suitable? > > > > > > > > > > It works by loading a shared library specified in the world file > like > > > > > this: > > > > > > > > > > <controller:controllerName name="controller1" > plugin="controllerName.so"> > > > > > > > > > > The shared library has to be built with -module. > > > > > > > > > > Thanks, > > > > > David > > > > > > > > > > > ------------------------------------------------------------------------- > > > > > This SF.net email is sponsored by: Microsoft > > > > > Defy all challenges. Microsoft(R) Visual Studio 2008. > > > > > http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/ > > > > > _______________________________________________ > > > > > Playerstage-gazebo mailing list > > > > > [EMAIL PROTECTED] > > > > > https://lists.sourceforge.net/lists/listinfo/playerstage-gazebo > > > > > > > > > > > > > > > > > > > > > -- > > > > Jordi Polo Carres > > > > NLP laboratory - NAIST > > > > http://www.bahasara.org > > > > > > > ------------------------------------------------------------------------- > > Check out the new SourceForge.net Marketplace. > > It's the best place to buy or sell services for > > just about anything Open Source. > > > http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace > > > > > > > > _______________________________________________ > > Playerstage-gazebo mailing list > > Playerstage-gazebo@lists.sourceforge.net > > https://lists.sourceforge.net/lists/listinfo/playerstage-gazebo > > > > > > -- > > Jordi Polo Carres > NLP laboratory - NAIST > http://www.bahasara.org > > ------------------------------------------------------------------------- > Check out the new SourceForge.net Marketplace. > It's the best place to buy or sell services for > just about anything Open Source. > > http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace > > _______________________________________________ > Playerstage-gazebo mailing list > Playerstage-gazebo@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/playerstage-gazebo > > ------------------------------------------------------------------------- Check out the new SourceForge.net Marketplace. It's the best place to buy or sell services for just about anything Open Source. http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace _______________________________________________ Playerstage-gazebo mailing list Playerstage-gazebo@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/playerstage-gazebo
