On 2007-11-14 18:13-0000 Andrew Ross wrote: > On Thu, Nov 08, 2007 at 05:00:28PM -0800, Alan Irwin wrote: >> On 2007-11-08 10:57-0800 Alan W. Irwin wrote: >> >> To summarize, the warning message was >> >> warning: deprecated conversion from string constant to ???char*??? >> >> and it occurred for >> >> bindings/wxwidgets/wxPLplotstream.cpp: line 66 >> >> drivers/wxwidgets.cpp: lines 160 (21 times), 382, 563 (6 times), 1475, 1620, >> and 1746 >> >> Werner, could you take care of this please? >> >> This warning message also occurred in a large subset of the C++ examples. >> >> Andrew, could you take care of at least some of these warnings working from >> the low numbers to the high numbers? Once I see one of your commits telling >> how to deal with the problem, I could work from the high numbers down to >> give you a hand cleaning this up. > > I've tested with g++-4.2 under Ubuntu and found the same. > > I've got patches to correct all these problems (except for wxwidgets > which I've left to Werner). This is quite intrusive though and involves > making several char * arguments in the API into const char *. We've been > inconsistent about this in the past. For example labels are constant, > but char * arguments in the command line parsing are not. None of these > text string are modified by the functions and so they probably should be > const. > > Changed API functions are > plmap > plstripc > plParseOpts > plSetOpt > plparseopts > plsetopt > plMergeOpts > plsabort > plsexit > > and also the definition of the PLOptionTable structure. > > Are people happy for me to commit this? > > The other option is lots of explicit casting of (const char *) to (char > *) which is not pretty.
I like the idea of changing to a more consistent API. However, the timing of this just before a stable release is a concern. So I suggest living with the warning messages for now and holding back your API changes until just after the stable release. Also, at that time we should do everything right with such a backwards-incompatible API change. Warn of the API change in the 5.9.0 (developmental) release announcement, bump major library soname numbers appropriately, etc. In my view, the dust should settle quite nicely from this API change by the time of our next stable release (5.10.0), if the API changes are introduced immediately after this stable release. Alan __________________________ Alan W. Irwin Astronomical research affiliation with Department of Physics and Astronomy, University of Victoria (astrowww.phys.uvic.ca). Programming affiliations with the FreeEOS equation-of-state implementation for stellar interiors (freeeos.sf.net); PLplot scientific plotting software package (plplot.org); the libLASi project (unifont.org/lasi); the Loads of Linux Links project (loll.sf.net); and the Linux Brochure Project (lbproject.sf.net). __________________________ Linux-powered Science __________________________ ------------------------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/ _______________________________________________ Plplot-devel mailing list Plplot-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/plplot-devel
