On Wed, Nov 14, 2007 at 02:27:12PM -0800, Alan Irwin wrote: > On 2007-11-14 18:13-0000 Andrew Ross wrote: > > > I've tested with g++-4.2 under Ubuntu and found the same. > > > > I've got patches to correct all these problems (except for wxwidgets > > which I've left to Werner). This is quite intrusive though and involves > > making several char * arguments in the API into const char *. We've been > > inconsistent about this in the past. For example labels are constant, > > but char * arguments in the command line parsing are not. None of these > > text string are modified by the functions and so they probably should be > > const. > > > > Changed API functions are > > plmap > > plstripc > > plParseOpts > > plSetOpt > > plparseopts > > plsetopt > > plMergeOpts > > plsabort > > plsexit > > > > and also the definition of the PLOptionTable structure. > > > > Are people happy for me to commit this? > > > > The other option is lots of explicit casting of (const char *) to (char > > *) which is not pretty. > > I like the idea of changing to a more consistent API. However, the timing of > this just before a stable release is a concern. So I suggest living with > the warning messages for now and holding back your API changes until just > after the stable release. Also, at that time we should do everything right > with such a backwards-incompatible API change. Warn of the API change in > the 5.9.0 (developmental) release announcement, bump major library soname > numbers appropriately, etc. In my view, the dust should settle quite nicely > from this API change by the time of our next stable release (5.10.0), if the > API changes are introduced immediately after this stable release.
That was my view too. I'll leave this until after the 5.8.0 release. Andrew ------------------------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/ _______________________________________________ Plplot-devel mailing list Plplot-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/plplot-devel
