On 2009-04-24 09:16, Alan W. Irwin wrote:
> Hi Vadim:
> 
> Thanks for your LIB_TAG bug report which was caused by some of our
> visibility logic assuming LIB_TAG was always "d".  I have now fixed that 
> bug
> (revision 9843).  Please try out that revision to make sure it works for 
> you
> (with an additional suffix of "d", see below).
> 
> A question for all developers here:
> 
> During investigation of the above bug, I was reminded that our present 
> build
> system has the following logic in cmake/modules/double.cmake.
> 
> if(PL_DOUBLE)
>   set(LIB_TAG "${LIB_TAG}d")
> endif(PL_DOUBLE)
> 
> PL_DOUBLE defaults to ON (since most people want the double-precision
> version of the PLplot libraries).  So what this logic normally does is
> appends the suffix "d" (meaning "double precision") to whatever suffix you
> specify for LIB_TAG as a cmake option.
> 
> I would prefer the following logic instead:
> 
> if(PL_DOUBLE AND NOT DEFINED LIB_TAG)
>   set(LIB_TAG "d")
> endif(PL_DOUBLE AND NOT DEFINED LIB_TAG)
> 
> In other words, if somebody specifies a library name suffix on the command
> line including the null string, let us assume they know what they want so
> that is exactly what they get.  However, if -DLIB_TAG is not specified at
> all by the user, then the suffix will be "d" for the usual (default)
> PL_DOUBLE case just like it is now.
> 
> Does any developer here mind this proposed change to the build-system 
> logic?
> 

Hi Alan,

I think that is an excellent idea: it makes that feature much clearer
and more useful - it allows for people to develop a set of
configurations (should they need that), besides configurations that are
useful for debugging, also for use with static device drivers and so on.

Regards,

Arjen


Delft Hydraulics, GeoDelft, the Subsurface and Groundwater unit of TNO and 
parts of Rijkswaterstaat have joined forces in a new independent institute for 
delta technology, Deltares. Deltares combines knowledge and experience in the 
field of water, soil and the subsurface. We provide innovative solutions to 
make living in deltas, coastal areas and river basins safe, clean and 
sustainable. 

 

DISCLAIMER: This message is intended exclusively for the addressee(s) and may 
contain confidential and privileged information. If you are not the intended 
recipient please notify the sender immediately and destroy this message. 
Unauthorized use, disclosure or copying of this message is strictly prohibited.
The foundation 'Stichting Deltares', which has its seat at Delft, The 
Netherlands, Commercial Registration Number 41146461, is not liable in any way 
whatsoever for consequences and/or damages resulting from the improper, 
incomplete and untimely dispatch, receipt and/or content of this e-mail.





------------------------------------------------------------------------------
Crystal Reports - New Free Runtime and 30 Day Trial
Check out the new simplified licensign option that enables unlimited
royalty-free distribution of the report engine for externally facing 
server and web deployment.
http://p.sf.net/sfu/businessobjects
_______________________________________________
Plplot-devel mailing list
Plplot-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/plplot-devel

Reply via email to