On Fri, 24 Apr 2009 00:16:05 -0700 (PDT) "Alan W. Irwin" <ir...@beluga.phys.uvic.ca> wrote:
AWI> Thanks for your LIB_TAG bug report which was caused by some of our
AWI> visibility logic assuming LIB_TAG was always "d". I have now fixed that
bug
AWI> (revision 9843). Please try out that revision to make sure it works for
you
AWI> (with an additional suffix of "d", see below).
Thanks for fixing it, it does work now!
AWI> A question for all developers here:
AWI>
AWI> During investigation of the above bug, I was reminded that our present
build
AWI> system has the following logic in cmake/modules/double.cmake.
AWI>
AWI> if(PL_DOUBLE)
AWI> set(LIB_TAG "${LIB_TAG}d")
AWI> endif(PL_DOUBLE)
AWI>
AWI> PL_DOUBLE defaults to ON (since most people want the double-precision
AWI> version of the PLplot libraries). So what this logic normally does is
AWI> appends the suffix "d" (meaning "double precision") to whatever suffix you
AWI> specify for LIB_TAG as a cmake option.
AWI>
AWI> I would prefer the following logic instead:
AWI>
AWI> if(PL_DOUBLE AND NOT DEFINED LIB_TAG)
AWI> set(LIB_TAG "d")
AWI> endif(PL_DOUBLE AND NOT DEFINED LIB_TAG)
I realize the question wasn't really addressed to me but I can only repeat
what I wrote before, i.e.:
AWI> P.S. It would be also nice if LIB_TAG setting actually overrode the "d"
AWI> suffix added when using "double"
IOW I absolutely agree with your proposal.
Thanks again,
VZ
pgpubjiKrKGih.pgp
Description: PGP signature
------------------------------------------------------------------------------ Crystal Reports - New Free Runtime and 30 Day Trial Check out the new simplified licensign option that enables unlimited royalty-free distribution of the report engine for externally facing server and web deployment. http://p.sf.net/sfu/businessobjects
_______________________________________________ Plplot-devel mailing list Plplot-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/plplot-devel
