On 2009-06-19 06:35+0300 Dmitri Gribenko wrote: > Use QMutexLocker in Qt driver. RAII is always better than managing > resources by hand.
Hi Dmitri: This patch has been reviewed and approved by Alban, but not tested by him. My light testing (make test_noninteractive in the installed examples tree) showed no obvious issues. Therefore, I have committed this patch (revision 10055). Thanks! Hi Andrew: I have addressed this post to you as well because the previous commit message that put in a mutex for this device implied you had a thread safety test for the qt device at that time: ******** r9765 | airwin | 2009-03-21 08:39:08 -0700 (Sat, 21 Mar 2009) | 8 lines AWI for Alban Rochel. - Introduce a mutex to make driver thread safe. Andrew noticed that when 2 qtwidgets were running on 2 streams, closing them didn't close the driver properly. This issue should be fixed by this change. ******** Could you apply the same test for this new way of handling the qt mutex? Also, if you could share the details of your test (i.e., what example to run interactively and how to identify when the driver is not closed properly), I should be able to incorporate it into our interactive test suite so that anybody could run the test on any platform. Alan __________________________ Alan W. Irwin Astronomical research affiliation with Department of Physics and Astronomy, University of Victoria (astrowww.phys.uvic.ca). Programming affiliations with the FreeEOS equation-of-state implementation for stellar interiors (freeeos.sf.net); PLplot scientific plotting software package (plplot.org); the libLASi project (unifont.org/lasi); the Loads of Linux Links project (loll.sf.net); and the Linux Brochure Project (lbproject.sf.net). __________________________ Linux-powered Science __________________________ ------------------------------------------------------------------------------ Crystal Reports - New Free Runtime and 30 Day Trial Check out the new simplified licensing option that enables unlimited royalty-free distribution of the report engine for externally facing server and web deployment. http://p.sf.net/sfu/businessobjects _______________________________________________ Plplot-devel mailing list Plplot-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/plplot-devel
